Hello, so I am experiencing a problem in my javascript app where I cannot stop a user spamming a button. The app is used to draw three random numbers from a range. when a button is clicked, a number is drawn and a special animation plays, then the next number can be drawn. I am having trouble preventing the user from spamming the draw button. So far I have tried using a local variable called enabled which is set to false when the animation is playing and checked to be true before the actual animation function executes (its set back to false after it executes). I have also tried to remove and add the event listener of the button dynamically when it is pressed. Is there any way you guys think I can solve the issue? Thank you. The code should be in an image with the post.
For your own sanity, please use a formatter for your IDE. This will also help when others (and you) read the code, as indentation is a convenience for understanding program flow. From what I see:
- Your
enable
anddisable
functions are never called for this portion of code - You use a possibly undeclared
enabled
variable, if so it never passes scopes between thehandleClick
andanimation
methods - You do not use any callback or
await
forinvoke
orupdateCurrentBox
, causing all the code after either to immediately run. As a result,enabled
is neverfalse
, since it just instantly flips back totrue
. I’m not sure what libraryinvoke
is from, but there should be a callback or the function returns aPromise
which can beawait
ed.
- Your
Rather than messing with the EventListener, wouldn’t it be easier to just throttle the function that it calls? You can find a bunch of articles online that will explain how to implement a throttle (and also a debouncer, which is similar, but not quite what you’re looking for; a throttle allows a function to be called immediately unless it’s already been called too recently, while a debouncer waits every time before calling the function and restarts the wait timer every time someone tried to call the function).
Just a heads up: if the spam is a problem, you also need to handle it server-side. Anything you do in JS is fencepost security, they’ll trivially get around it.
I have a dumb question… Are you declaring “enabled” somewhere outside of any of these functions?
You need a reference to your Eventhandler. So instead of just giving an anonymous callback function to your
addEventHandler
store it in a variable instead. Then your can callremoveEventHandler
with the same event type and the variable of your Eventhandler you want to remove.