• traches@sh.itjust.works
    link
    fedilink
    English
    arrow-up
    47
    arrow-down
    1
    ·
    2 months ago

    Agreed. OP was doing well until they replaced the if statements with ‚function call || throw error’. That’s still an if statement, but obfuscated.

    • BrianTheeBiscuiteer@lemmy.world
      link
      fedilink
      arrow-up
      7
      ·
      2 months ago

      Don’t mind the || but I do agree if you’re validating an input you’d best find all issues at once instead of “first rule wins”.

      • rooster_butt@lemm.ee
        link
        fedilink
        arrow-up
        3
        ·
        2 months ago

        Short circuiting conditions is important. Mainly for things such as:

        if(Object != Null && Object.HasThing) …

        Without short circuit evaluation you end up with a null pointer exception.