• 0 Posts
  • 30 Comments
Joined 1 year ago
cake
Cake day: July 1st, 2023

help-circle









  • I made a branch, make commits, and then make a PR. I don’t care about the number of commits because sometimes a reviewer might be able to make more sense of a PR if they view each commit instead of all the changes at once.

    For us we just make sure that the branch builds and passes tests before merging it in, and just do a general look over to make sure everything looks correct, follows best practices, etc. if the UI was changed I usually add screenshots of before/after or a screen recording of me using the feature. Sometimes these can really help a reviewer understand what all the changes mean.











  • Thanks for this, it makes a lot of sense actually. Oh well, my mom has her car and the warranty she will hopefully never need, but it’s there if she does. I guess it all comes down to care tactics in the dealership, pressuring you to buy warranties and such that you may not need and cannot buy at any other time except right then.

    I’ll be sticking with the recently used philosophy for the future though.