• 9 Posts
  • 273 Comments
Joined 2 years ago
cake
Cake day: July 6th, 2023

help-circle




  • BB_C@programming.devtoRust@programming.devAnnouncing Rust 1.89.0
    link
    fedilink
    arrow-up
    2
    arrow-down
    1
    ·
    2 months ago

    (stating the obvious)

    You can already :

    res_res??;
    // or
    res_res?.map_err(..)?;
    // or
    res_res.map_err(...)??;
    // or
    res_res.map_err(...)?.map_err(...)?;
    

    With res_res.flatten()?, you don’t know where you got the error anymore, unless the error type itself is “flatten-aware”, which is a bigger adjustment than the simple ergonomic library addition, and can become itself a problematic pattern with its own disadvantages.


  • BB_C@programming.devtoRust@programming.devAnnouncing Rust 1.89.0
    link
    fedilink
    arrow-up
    4
    arrow-down
    1
    ·
    2 months ago

    Result::flatten() is probably my favorite addition

    It’s rare to a have a negative reaction to a library addition. But I don’t like this one at all actually.

    For me, error contexts are as important as the errors themselves. And ergonomically helping with muddying these contexts is not a good thing!








  • Very quickly skimmed Cargo.toml and main.rs.

    • What’s with the title-case name?
    • The name proximity to axum is also not cool.
    • You should mention that this is built on top of axum in the project description.
    • How did you end up using both lazy_static and once_cell, when OnceLock has been stable since 1.70 and axum’s MSRV is 1.75?
    • Why did you copy-paste min-sized-rust flags?
    • You can actually print like this:
    println!("{proto}://{ip}:{port}");
    

    instead of

    println!("{0}://{1}:{2}", proto, ip, port);
    

    and the positional indices are redundant anyway.

    • Since you’re depending on tracing, you should actually use tracing::error instead of eprintln!("❌ ...").

    Okay. I will stop here.






  • Along the same vein, too many open source projects don’t factor in non-“gnu/linux” environments from the start.

    No one is entitled to anything from open-source projects.

    I spent time making sure one of my public tools was cross platform once. This was pre-Rust (a C project), and before CI runners were commonly available.

    I did manage it with relative ease, but Mac/mac (what is it now?) without hardware or VMware wasn’t fun (or even supported/allowed). Windows was a space hog and it’s a shit non-POSIX OS created by shits anyway, and Cygwin/MSYS wouldn’t have cut it for multiple reasons including performance. The three major BSDs, however, were very easy (I had prior experience with FreeBSD, but it would have been easy in any case).

    People seem to have forgotten that doing open-source was supposed to be fun first and for most. Or rather, the new generation seems to never have gotten that memo.

    POSIX is usually where a good balance between fun and public service is struck. Whether Mac/mac is included depends on the project, AND the developers involved. With CLI tools, supporting Mac/mac is often easy, especially nowadays with CI runners. With GUIs, it’s more complicated/situational.

    Windows support should always be seen as charity, not an obligation, for all projects where it’s not the primary target platform.




  • Yeah, apologies for not communicating the issue clearly.

    cp config.example.toml config.toml
    ./y.sh prepare
    ./y.sh build --sysroot
    ./y.sh clean all
    # above commands finish with success
    # below, building succeeds, but it later fails with "error: failed to load source for dependency `rustc-std-workspace-alloc`
    ./y.sh test --release 
    

    And then trying to use the “release” build fails:

    % CHANNEL="release"  ./y.sh cargo build  --manifest-path tests/hello-world/Cargo.toml
    [BUILD] build system
        Finished `release` profile [optimized] target(s) in 0.03s
    Using `/tmp/rust/rustc_codegen_gcc/build/libgccjit/d6f5a708104a98199ac0f01a3b6b279a0f7c66d3` as path for libgccjit
       Compiling mylib v0.1.0 (/tmp/rust/rustc_codegen_gcc/tests/hello-world/mylib)
    error[E0463]: can't find crate for `std`
      |
      = note: the `x86_64-unknown-linux-gnu` target may not be installed
      = help: consider downloading the target with `rustup target add x86_64-unknown-linux-gnu`
      = help: consider building the standard library from source with `cargo build -Zbuild-std`
    
    For more information about this error, try `rustc --explain E0463`.
    error: could not compile `mylib` (lib) due to 1 previous error
    

    I will make sure to report issues directly in the future, although from account(s) not connected to this username.